Skip to content

WIP: Add namespace column to user_callouts

Luke Bennett requested to merge add-namespaces-to-callouts into master

What does this MR do?

Add namespace column to user_callouts table.

To be used in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9809

As explained in https://gitlab.com/gitlab-org/gitlab-ee/issues/8237#note_146586920, we would like to have per-namespace user callouts. For example, a callout of type TANUKI_CALLOUT dismissed on gitlab-org should not be dismissed on not-gitlab-org.

Post-deployment data migration

If this is deployed to production after the initial version of https://gitlab.com/gitlab-org/gitlab-ee/issues/8237 lands, we will have a some GOLD_TRIAL_BILLINGS callout rows that wont have a namespace value and should be deleted as this callout will be ignored and those rows will sit around doing nothing. I don't expect there to be lots but it's going to be worth cleaning up so we have more consistent and predictable records.

If this is merged before then and we can merge an MR that updates the first version before its even deployed, we wont need to do a data migration. Chances seem slim given its the 2nd.

What are the relevant issue numbers?

Part of https://gitlab.com/gitlab-org/gitlab-ee/issues/8237

Does this MR meet the acceptance criteria?

Edited by Luke Bennett

Merge request reports