Skip to content

Replace visitUrl with Gl-Link in ci-badge-link

Lee Tickett requested to merge visitUrl-new-window-support into master

What does this MR do and why?

@cwoolley-gitlab called out that we can't "open in new window/tab". While looking to add that functionality to visitUrl @dpisek called out that we could probably just use gl-link here (and gain other benefits like supporting middle click, right click etc).

This MR replaces visitUrl with gl-link.

Screenshots or screen recordings

Before

Screenshot_2022-09-16_at_20.05.21

After

Screenshot_2022-09-16_at_20.08.04

Recreation steps

  1. Navigate to a project's pipeline list e.g. http://gdk.test:3000/flightjs/Flight/-/pipelines
  2. Select a pipeline e.g. http://gdk.test:3000/flightjs/Flight/-/pipelines/2
  3. Command/ctrl click the status badge in the top left (should open in a new tab/window); or
  4. Right click (you should see the open in new tab/window option); or
  5. Middle click (should open in a new tab/window); or
  6. Hover over (you should see the link path in the status bar)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lee Tickett

Merge request reports