Cleanup «New tag» page
What does this MR do and why?
Cleans up the «New tag» page:
- Aligns form labels on top, like defined in Pajamas
- Removes unnecessary borders & backgrounds
- Aligns with other recent efforts to clean up «New» pages, see #361641 (closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to http://gdk.test:3000/flightjs/Flight/-/tags/new in GDK
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Beautifying our UI UI polish UX featureenhancement frontend groupfoundations sectiondev severity4 typefeature + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
changed milestone to %15.4
mentioned in issue #367893 (closed)
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@dbalexandre
,@rspeicher
,@wortschi
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga ( @ghavenga
) (UTC+2, same timezone as@seggenberger
)Aleksei Lipniagov ( @alipniagov
) (UTC+3, 1 hour ahead of@seggenberger
)frontend Samantha Ming ( @sming-gitlab
) (UTC+2, same timezone as@seggenberger
)David O'Regan ( @oregand
) (UTC+10, 8 hours ahead of@seggenberger
)test for spec/features/*
Gregory Havenga ( @ghavenga
) (UTC+2, same timezone as@seggenberger
)Maintainer review is optional for test for spec/features/*
UX Andy Volpe ( @andyvolpe
) (UTC-4, 6 hours behind@seggenberger
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerHey @beckalippert a small UX change to review for you
requested review from @beckalippert
removed backend label
added documentation label
- A deleted user
added backend label
@beckalippert
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @jrushford
- Resolved by Enrique Alcántara
Hey @jrushford can you do the frontend review? Thanks!
requested review from @ealcantara and removed review request for @jrushford
enabled an automatic merge when the pipeline for 6c5f9d20 succeeds
mentioned in commit 6c1b612d
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1453 (merged)
added devopsmanage label and removed 1 deleted label
added releasedpublished label and removed releasedcandidate label