Skip to content

Migrate manage redis_hll metrics to instrumentation classes

What does this MR do and why?

Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data was used to collect all Redis HLL metrics data and add it to Service Ping payload. With new instrumentation classes framework there is new unified approach into adding metrics into Service Ping payload. This MR removes manage metrics category from .unique_events_data and allows new framework automation to fill them in.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

pry(main)> Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data['manage']
=> nil

pry(main)> ServicePing::BuildPayload.new.execute[:redis_hll_counters]['manage']
=> {array of metrics}

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #368996 (closed)

Edited by Niko Belokolodov

Merge request reports