Skip to content
Snippets Groups Projects

Precompile environments.css page bundle

Merged Precompile environments.css page bundle
ali/precompile-environments-css-page-bundle into master
Merged Alishan Ladhani requested to merge ali/precompile-environments-css-page-bundle into master

What does this MR do and why?

In !97152 (merged), we deleted ee/app/assets/stylesheets/page_bundles/environments.scss and removed page_bundles/environments.css from config.assets.precompile, but the CE version of that file still exists (https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/stylesheets/page_bundles/environments.scss).

In development, we get an error when attempting to load the Environments page:

image

Adding page_bundles/environments.css back to config.assets.precompile fixes the error.

Related to #367793 (closed)

Slack thread for more context: https://gitlab.slack.com/archives/CBZGR90A2/p1662664187395129

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alishan Ladhani

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply