Skip to content

Log event when TokenVerificationService returns an error response

Eugie Limpin requested to merge log-arkose-token-verify-failed-event into master

What does this MR do and why?

Currently, we are logging the event when token verification succeeds in Arkose::TokenVerificationService. This logging happens regardless of whether the service returns a ServiceResponse.success or ServiceResponse.error.

This MR updates the service to log the event when ServiceResponse.error is returned because the challenge was unsolved. This will enable us debug issues (like gitlab-com/www-gitlab-com#13927 (closed)) easier by being able to look at the Arkose Labs Verify API response for users that have failed to login/signup.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eugie Limpin

Merge request reports