Dropzone: Change border-radius to default radius
What does this MR do and why?
Follow-up to !96886 (merged) to unify the border-radius
used on elements.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Go to an Issue
- Check the Dropzone element
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added Beautifying our UI UI polish UX featureenhancement frontend groupfoundations sectiondev typefeature + 1 deleted label
assigned to @seggenberger
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
changed milestone to %15.4
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @jivanvl
,@iamphill
,@wortschi
,@markrian
,@himkp
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
added 1 commit
- 0cb2137e - Dropzone: Change border-radius to default radius
added severity4 label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Artur Fedorov ( @arfedoro
) (UTC+2, same timezone as@seggenberger
)Dave Pisek ( @dpisek
) (UTC+2, same timezone as@seggenberger
)UX Matthew Nearents ( @mnearents
) (UTC-7, 9 hours behind@seggenberger
)Maintainer review is optional for UX ~"codeowners" Reviewer review is optional for ~"codeowners" Jan Provaznik ( @jprovaznik
) (UTC+2, same timezone as@seggenberger
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Sascha Eggenberger
Hey @nickleonard can you quickly do the UX review on this tiny 🤏 change? TY!
requested review from @nickleonard
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e8a9df00 and ed8f3cd1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - 0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for e8a9df00. So we have used data from: 81853c1c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved review request for @nickleonard
@nickleonard
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @eduardosanz
Hey @eduardosanz can you do the frontend review on this tiny change?
- Resolved by Sascha Eggenberger
- Resolved by Andrew Fontaine
@seggenberger, thanks for the improvement. I approved it.
added 1 commit
- fc50b024 - Dropzone: Change border-radius to default radius
requested review from @afontaine
Allure report
allure-report-publisher
generated test report!e2e-review-qa-blocking:
test report for ed8f3cd1expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Create | 28 | 0 | 1 | 28 | 29 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Manage | 57 | 0 | 3 | 57 | 60 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 157 | 0 | 9 | 148 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
@seggenberger this looks good to me, but I am going OOO so if this merge fails please feel free to ask another maintainer to take a look.
enabled an automatic merge when the pipeline for 4f5e2fa1 succeeds
- Resolved by Jan Provaznik
Hey @jprovaznik can you help me fix the pipeline here? It seems it fails because of an unrelated error.
Or do I just need to rebase this and give it another try?
added 358 commits
-
fc50b024...fdcfe3b7 - 357 commits from branch
master
- ed8f3cd1 - Dropzone: Change border-radius to default radius
-
fc50b024...fdcfe3b7 - 357 commits from branch
added QA label
removed QA label
Thanks @seggenberger, given that this has all approvals (UX/FE), I'll go ahead and set MWPS
enabled an automatic merge when the pipeline for 7d19440a succeeds
mentioned in commit 1dd42c8b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowproduction label and removed workflowcanary label
added workflowstaging label and removed workflowproduction label
added workflowpost-deploy-db-staging label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1453 (merged)
added devopsmanage label and removed 1 deleted label
added releasedpublished label and removed releasedcandidate label