Skip to content
Snippets Groups Projects

Dropzone: Change border-radius to default radius

Merged Sascha Eggenberger requested to merge dropzone-border-fix into master
All threads resolved!

What does this MR do and why?

Follow-up to !96886 (merged) to unify the border-radius used on elements.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. Go to an Issue
  2. Check the Dropzone element

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Sanz García approved this merge request

    approved this merge request

  • added 1 commit

    • fc50b024 - Dropzone: Change border-radius to default radius

    Compare with previous version

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • requested review from @afontaine

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa-blocking: :exclamation: test report for ed8f3cd1

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
    | Create                             | 28     | 0      | 1       | 28    | 29    | ❗     |
    | Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Manage                             | 57     | 0      | 3       | 57    | 60    | ❗     |
    | Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 157    | 0      | 9       | 148   | 166   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Andrew Fontaine resolved all threads

    resolved all threads

  • @seggenberger this looks good to me, but I am going OOO so if this merge fails please feel free to ask another maintainer to take a look.

  • Andrew Fontaine enabled an automatic merge when the pipeline for 4f5e2fa1 succeeds

    enabled an automatic merge when the pipeline for 4f5e2fa1 succeeds

  • Andrew Fontaine approved this merge request

    approved this merge request

  • Sascha Eggenberger aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • Sascha Eggenberger added 358 commits

    added 358 commits

    Compare with previous version

  • added QA label

  • removed QA label

  • Jan Provaznik resolved all threads

    resolved all threads

  • Thanks @seggenberger, given that this has all approvals (UX/FE), I'll go ahead and set MWPS :rocket:

  • Jan Provaznik enabled an automatic merge when the pipeline for 7d19440a succeeds

    enabled an automatic merge when the pipeline for 7d19440a succeeds

  • merged

  • Jan Provaznik mentioned in commit 1dd42c8b

    mentioned in commit 1dd42c8b

  • added workflowproduction label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading