Adds redirection when cleanup policy is saved
What does this MR do and why?
Forth MR under move container registry cleanup policies to a separate page.
This MR deals with redirection to settings page when Save changes/Cancel
is clicked on cleanup image tags page described in comment
It also fixes issue where clean up page allows saving changes when no changes are made.
Iteration | MR |
---|---|
Adds new route | Adds new route to show cleanup image tag settings (!94988 - merged) |
Copy container cleanup form | Copies container registry cleanup form to new page (!96219 - merged) |
Update settings page to link new route | Updates container registry project settings (!96799 - merged) |
Redirect to settings page when saved or canceled | This MR |
Noticed and fixed issue with settings submenu not being expanded for cleanup image tags page
Screenshots or screen recordings
Cleanup image tags form
Alert
If Updates container registry project settings (!96799 - merged) gets merged before this then the settings page should look different to screenshot but the alert & redirection behavior should remain
How to set up and validate locally
- Enable container registry in GDK https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
- Login as admin
- Visit any project.
- Visit Settings > Packages & Registries on the sidebar & then append
/cleanup_image_tags
to the URL to visit cleanup page - Should be able to modify the settings & not see any errors.
- Verify The container registry clean up page allow savi... (#371882 - closed)
- Clicking on
Save changes
should redirect to settings page & show success alert - Clicking on
Cancel
should redirect to settings page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #363426 (closed)
Closes #371882 (closed)