Hide add oncall schedule buttons for unauthorized users
requested to merge 363271-on-call-schedules-create-schedule-and-rotation-buttons-should-be-hidden-for-certain-users into master
What does this MR do and why?
Describe in detail what your merge request does and why.
Removal of edit and delete buttons in on-call schedules for users with less than maintainer role
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| before | after | |
|---|---|---|
| with schedules |  |
 |
| without schedules |  |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
TO do this you must impersonate a developer on the project, if you use the default gdk pre-loaded projects, it is best to impersonate victor as they are a developer on 2 projects ("GitLab shell" and "GitLab test")
- View on-call schedules as admin (or at least maintainer), access by left hand menu, monitor > on-call schedules
- Add an oncall schedule if project does not have one
- Impersonate a user with developer role
- Return to view the on-call schedules that were just created and notice the lack of edit buttons
- As impersonated developer also visit a project's on-call schedule where none exist so you can see the updated copy and removed "add schedule" button
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #363271 (closed)
Edited by James Rushford