Legacy license compliance widget removal
What does this MR do and why?
As a follow up to #367703 (closed)
This removes the feature flag code.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
-
Reach out to me for a demo, or attempt steps below -
Clone the https://gitlab.com/gitlab-examples/security/security-reports project locally -
Manually trigger the pipeline to run for Master
. This can be done by going to theCI/CD
->Pipelines
tab on the left nav and then clicking theRun Pipeline
button. -
Set up Allowed/Denied licenses in https://<localhost>/<group>/<project>/-/licenses#policies
-
Create a new MR. I suggest changing something simple like a letter or two in the README.md
file. We just need a pipeline to complete and run. The sample project uses test reports to generate the data so doesn't matter what you change just need a MR. -
Go to the MR and look for the license compliance widget.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #367704 (closed)
Merge request reports
Activity
changed milestone to %15.4
assigned to @farias-gl
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @reprazent
,@jivanvl
,@afontaine
,@psimyn
,@kushalpandya
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Thomas Hutterer ( @thutterer
) (UTC+2, same timezone as@farias-gl
)Sean McGivern ( @smcgivern
) (UTC+1, 1 hour behind@farias-gl
)frontend Tristan Read ( @tristan.read
) (UTC+12, 10 hours ahead of@farias-gl
)Peter Hegman ( @peterhegman
) (UTC-7, 9 hours behind@farias-gl
)QA Aleksandr Lyubenkov ( @alyubenkov
) (UTC+2, same timezone as@farias-gl
)Maintainer review is optional for QA test for spec/features/*
Will Meek ( @willmeek
) (UTC+1, 1 hour behind@farias-gl
)Maintainer review is optional for test for spec/features/*
~"codeowners" Reviewer review is optional for ~"codeowners" Mark Chao ( @lulalala
) (UTC+8, 6 hours ahead of@farias-gl
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @jannik_lehmann
removed review request for @jannik_lehmann
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 18da40a8 and 1a8792a7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - -0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for 18da40a8. So we have used data from: 5b39c3e3.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- 68ba9a4e - First pass legacy license compliance widget removal
- Resolved by David Pisek
added 100 commits
-
68ba9a4e...b70d5d7a - 99 commits from branch
master
- e790da18 - First pass legacy license compliance widget removal
-
68ba9a4e...b70d5d7a - 99 commits from branch
added pipeline:run-as-if-foss label
- Resolved by David Pisek
@farias-gl Thanks for doing this cleanup work LGTM! @dpisek could you give the Frontend a second pair of eyes?
@bmarjanovic could you do the backend review on this MR?
@dchevalier2 could you do the QA review on this MR?
@willmeek could you do the test review on this MR?
Thanks everybody
Edited by Jannik Lehmann
requested review from @dpisek, @bmarjanovic, @dchevalier2, and @willmeek
@jannik_lehmann
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed workflowin dev label
- Resolved by David Pisek
- Resolved by David Pisek
requested review from @alexpooley
removed review request for @dchevalier2
added typemaintenance label and removed typefeature label
removed featureenhancement label
- Resolved by David Pisek
@farias-gl - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
added 84 commits
-
e790da18...535a333d - 82 commits from branch
master
- 209dd725 - First pass legacy license compliance widget removal
- c6989ade - Apply maintainer feedback
-
e790da18...535a333d - 82 commits from branch
mentioned in issue #372611
- Resolved by David Pisek
@dpisek applied your patch! Thanks for that. Also, responded to your questions. The failure looks flakey and unrelated for the cloud activation spec #368062 (comment 1088850764)
Edited by -
enabled an automatic merge when the pipeline for bb8a4a41 succeeds
Allure report
allure-report-publisher
generated test report!e2e-review-qa-blocking:
test report for 1a8792a7expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Manage | 57 | 0 | 3 | 57 | 60 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Create | 28 | 0 | 1 | 27 | 29 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 157 | 0 | 9 | 147 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1a8792a7expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 809 | 0 | 25 | 10 | 834 | ❗ | | Verify | 217 | 0 | 40 | 10 | 257 | ❗ | | Manage | 511 | 0 | 20 | 10 | 531 | ❗ | | Fulfillment | 11 | 1 | 56 | 1 | 68 | ❌ | | Protect | 10 | 0 | 0 | 0 | 10 | ✅ | | Release | 20 | 0 | 0 | 0 | 20 | ✅ | | Secure | 105 | 0 | 10 | 0 | 115 | ✅ | | Plan | 293 | 0 | 0 | 0 | 293 | ✅ | | Package | 161 | 0 | 33 | 1 | 194 | ❗ | | Version sanity check | 0 | 0 | 5 | 0 | 5 | ➖ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2170 | 1 | 205 | 32 | 2376 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
enabled an automatic merge when the pipeline for ce895e20 succeeds
mentioned in commit 37eeb68b
mentioned in issue gitlab-com/www-gitlab-com#13724 (closed)
added workflowstaging-canary label