Skip to content
Snippets Groups Projects

Legacy license compliance widget removal

Merged - requested to merge 367704-remove-license-compliance-flag into master

What does this MR do and why?

As a follow up to #367703 (closed)

This removes the feature flag code.

Screenshots or screen recordings

https://gitlab.com/gitlab-org/gitlab/uploads/1e4db1ea788146424c370afe1e3986f5/Screen_Shot_2022-08-10_at_3.07.06_PM.png

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

  • Reach out to me for a demo, or attempt steps below
  • Clone the https://gitlab.com/gitlab-examples/security/security-reports project locally
  • Manually trigger the pipeline to run for Master. This can be done by going to the CI/CD -> Pipelines tab on the left nav and then clicking the Run Pipeline button.
  • Set up Allowed/Denied licenses in https://<localhost>/<group>/<project>/-/licenses#policies
  • Create a new MR. I suggest changing something simple like a letter or two in the README.md file. We just need a pipeline to complete and run. The sample project uses test reports to generate the data so doesn't matter what you change just need a MR.
  • Go to the MR and look for the license compliance widget.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #367704 (closed)

Edited by -

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added QA backend labels

    added QA backend labels

  • - added 100 commits

    added 100 commits

    Compare with previous version

  • Jannik Lehmann approved this merge request

    approved this merge request

  • :wave: @jannik_lehmann, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • removed workflowin dev label

  • David Pisek
  • David Pisek
  • Will Meek approved this merge request

    approved this merge request

  • Bojan Marjanovic approved this merge request

    approved this merge request

  • requested review from @alexpooley

  • Désirée Chevalier approved this merge request

    approved this merge request

  • Désirée Chevalier removed review request for @dchevalier2

    removed review request for @dchevalier2

  • - added typemaintenance label and removed typefeature label

    added typemaintenance label and removed typefeature label

  • - added 84 commits

    added 84 commits

    Compare with previous version

  • - mentioned in issue #372611

    mentioned in issue #372611

  • Alex Pooley approved this merge request

    approved this merge request

  • David Pisek approved this merge request

    approved this merge request

  • David Pisek resolved all threads

    resolved all threads

  • David Pisek enabled an automatic merge when the pipeline for bb8a4a41 succeeds

    enabled an automatic merge when the pipeline for bb8a4a41 succeeds

  • - aborted the automatic merge because source branch was updated

    aborted the automatic merge because source branch was updated

  • - added 178 commits

    added 178 commits

    Compare with previous version

  • David Pisek approved this merge request

    approved this merge request

  • David Pisek resolved all threads

    resolved all threads

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa-blocking: :exclamation: test report for 1a8792a7

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Manage                             | 57     | 0      | 3       | 57    | 60    | ❗     |
    | Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
    | Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Create                             | 28     | 0      | 1       | 27    | 29    | ❗     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 157    | 0      | 9       | 147   | 166   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 1a8792a7

    expand test summary
    +---------------------------------------------------------------------------+
    |                              suites summary                               |
    +----------------------+--------+--------+---------+-------+-------+--------+
    |                      | passed | failed | skipped | flaky | total | result |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Create               | 809    | 0      | 25      | 10    | 834   | ❗     |
    | Verify               | 217    | 0      | 40      | 10    | 257   | ❗     |
    | Manage               | 511    | 0      | 20      | 10    | 531   | ❗     |
    | Fulfillment          | 11     | 1      | 56      | 1     | 68    | ❌     |
    | Protect              | 10     | 0      | 0       | 0     | 10    | ✅     |
    | Release              | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Secure               | 105    | 0      | 10      | 0     | 115   | ✅     |
    | Plan                 | 293    | 0      | 0       | 0     | 293   | ✅     |
    | Package              | 161    | 0      | 33      | 1     | 194   | ❗     |
    | Version sanity check | 0      | 0      | 5       | 0     | 5     | ➖     |
    | Systems              | 19     | 0      | 0       | 0     | 19    | ✅     |
    | Analytics            | 11     | 0      | 0       | 0     | 11    | ✅     |
    | Configure            | 1      | 0      | 15      | 0     | 16    | ✅     |
    | GitLab Metrics       | 2      | 0      | 1       | 0     | 3     | ✅     |
    +----------------------+--------+--------+---------+-------+-------+--------+
    | Total                | 2170   | 1      | 205     | 32    | 2376  | ❌     |
    +----------------------+--------+--------+---------+-------+-------+--------+
  • David Pisek enabled an automatic merge when the pipeline for ce895e20 succeeds

    enabled an automatic merge when the pipeline for ce895e20 succeeds

  • merged

  • David Pisek mentioned in commit 37eeb68b

    mentioned in commit 37eeb68b

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading