Fix BaseExporterSpec in Ruby 3
What does this MR do and why?
Fixes a test issue that only occurs in Ruby 3 since Rspec matchers match on hashes not kwargs.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #366942 (closed)
Merge request reports
Activity
changed milestone to %15.4
assigned to @mkaeppler
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @smcgivern
,@rymai
,@allison.browne
,@grzesiek
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Nicolas Dular ( @nicolasdular
) (UTC+2, same timezone as@mkaeppler
)Dylan Griffith ( @DylanGriffith
) (UTC-4, 6 hours behind@mkaeppler
)~"codeowners" Reviewer review is optional for ~"codeowners" Stan Hu ( @stanhu
) (UTC-7, 9 hours behind@mkaeppler
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Alex Pooley
- Ruby 2 pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/629538905
- Ruby 3 pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/629539718
Edited by Matthias Käppler
requested review from @rzwambag
requested review from @alexpooley and removed review request for @rzwambag
@rzwambag
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
mentioned in merge request !96885 (merged)
enabled an automatic merge when the pipeline for 81e9a46c succeeds
mentioned in commit 0f6fce38
mentioned in issue #366942 (closed)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label