Skip to content

Move updated thread control out of sidebar feature flag

Annabel Dunstone Gray requested to merge remove-ff-threads-control into master

What does this MR do and why?

  • Moves the thread control design updates out of the feature flag
  • Fixes various spacing bugs
  • Adds expand/collapse option when all threads are resolved

Screenshots or screen recordings

Feature flag on Feature flag off
Unresolved threads Screen_Shot_2022-09-01_at_1.53.41_PM Screen_Shot_2022-09-01_at_1.52.25_PM
All resolved Screen_Shot_2022-09-01_at_1.53.26_PM Screen_Shot_2022-09-01_at_1.52.42_PM

How to set up and validate locally

  1. Enable :moved_mr_sidebar
  2. View MR with unresolved threads (ellipsis dropdown should have options to expand/collapse threads and create issue to resolve all threads)
  3. View MR with threads all resolved (ellipsis dropdown should have only option to expand/collapse threads
  4. Disable :moved_mr_sidebar
  5. Follow steps 2 and 3; design and experience should be the same

Out of scope Since having a dropdown with only one item isn't ideal, perhaps use expand button icon instead of dropdown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to ✨ Beautifying our UI: Create:Code Review ✨ (#364574 - closed)

Edited by Annabel Dunstone Gray

Merge request reports