Adjust file header top if sidebar feature flag is off
What does this MR do and why?
- Fixes bug where file header on
Overview
tab wasn't in correcttop
location
Screenshots or screen recordings
How to set up and validate locally
- Check overview tab on MRs with both feature flag turned on and off
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @annabeldunstone
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@kushalpandya
,@jivanvl
,@godfat
,@iamphill
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
added Category:Code Review Workflow label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Axel García ( @agarciatesares
) (UTC-3, 3 hours ahead of@annabeldunstone
)Anna Vovchenko ( @anna_vovchenko
) (UTC+3, 9 hours ahead of@annabeldunstone
)~"codeowners" Reviewer review is optional for ~"codeowners" Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 3 hours ahead of@annabeldunstone
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Phil Hughes
@annabeldunstone - please see the following guidance and update this merge request.1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
changed milestone to %15.4
Allure report
allure-report-publisher
generated test report!e2e-review-qa-blocking:
test report for 7be48aebexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 24 | 29 | ❗ | | Plan | 47 | 0 | 1 | 43 | 48 | ❗ | | Manage | 57 | 0 | 3 | 46 | 60 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 157 | 0 | 9 | 127 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
@iamphill Can you please review?
requested review from @iamphill
Setting label(s) devopscreate groupcode review sectiondev based on ~"Category:Code Review" groupcode review.
added devopscreate groupcode review sectiondev labels
@iamphill
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 72 commits
-
f594be8c...67fcef19 - 71 commits from branch
master
- b53f420d - Adjust file header top if sidebar feature flag is off
-
f594be8c...67fcef19 - 71 commits from branch
added pipeline:run-all-jest label
added 31 commits
-
b53f420d...daacf555 - 30 commits from branch
master
- 27a66a4d - Adjust file header top if sidebar feature flag is off
-
b53f420d...daacf555 - 30 commits from branch
added 12 commits
-
27a66a4d...df67f9da - 11 commits from branch
master
- 7be48aeb - Adjust file header top if sidebar feature flag is off
-
27a66a4d...df67f9da - 11 commits from branch
added pipeline:run-as-if-foss label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2c43e0fd and 7be48aeb
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - 0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for 2c43e0fd. So we have used data from: 2f6a983d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger@iamphill Pipeline is finally passing; can you please merge this if ready?
enabled an automatic merge when the pipeline for fb93b45b succeeds
mentioned in commit 31eaa9e4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added bugux label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label