Fixed note buttons spacing on issues
What does this MR do and why?
The buttons on the note form didn't have any spacing when on mobile.
This MR fixes it.
Screenshots or screen recordings
Issues
Size | Old | New |
---|---|---|
Mobile | ![]() |
![]() |
Desktop | ![]() |
![]() |
Merge request (no changes)
Size | Old | New |
---|---|---|
Mobile | ![]() |
![]() |
Desktop | ![]() |
![]() |
How to set up and validate locally
- Navigate to any issue where you can add a note
- Find or create an existing note
- Try to add a note to that note to create a thread
- The
Reply
andCancel
buttons should have some spacing when on mobile
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Hey @zillemarco!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @zillemarco
4 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Mireya Andres ( @mgandres
) (UTC+8)Robert Hunt ( @rob.hunt
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@gitlab-bot label typebug bugmobile
- Resolved by Robert Hunt
Hi @agulina
If you have capacity, could you please review these few changes? Thanks a lot@gitlab-bot ready @agulina
added workflowready for review label and removed workflowin dev label
requested review from @agulina
@agulina
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-org/quality/triage-reports#8969 (closed)
- Resolved by Marco Zille
Hey @rob.hunt,
would you have time to look at this merge request, please? Thanks!
requested review from @rob.hunt
- Resolved by Robert Hunt
@agulina
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
mentioned in issue gitlab-org/quality/triage-reports#9014 (closed)
added workflowin review label and removed workflowready for review label
changed milestone to %15.4
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Rahul Chanila ( @rchanila
) (UTC+10)Robert Hunt ( @rob.hunt
) (UTC+1)~"codeowners" Reviewer review is optional for ~"codeowners" Kamil Trzciński ( @ayufan
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cc2b0027 and 0618fa54
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - 0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for cc2b0027. So we have used data from: 2f6a983d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger@zillemarco, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- Leave a
mentioned in commit 89b71369
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added groupproject management label
added devopsplan sectiondev labels
added Category:Issue Tracking label
added Category:Code Review Workflow label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added Leading Organization label and removed 1 deleted label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1453 (merged)
added releasedpublished label and removed releasedcandidate label