Skip to content

Update CODEOWNERS to support segregation of duties

Nick Nguyen requested to merge nhxnguyen-master-patch-63834 into master

What does this MR do and why?

This MR updates the CODEOWNERS file in order to support our segregation of duties requirements. It will be merged in coordination with enabling the following project-level MR approval rules:

  • Prevent approvals by users who add commits
  • Remove approvals by code owners if their files changed
  • Changing required approvals from 0 to 1 and enforcing the 1 required approval via CODEOWNERS.

These CODEOWNERS changes along with the above mentioned settings changes will satisfy the following requirements:

  • Any committer cannot merge code by themselves.
  • Any committer cannot approve their own code that they have committed.
  • Files with a .md extension in the /doc path are excluded from approvals.
  • The controls are technically enforced and have an audit trail.

Related to https://gitlab.com/gitlab-com/gl-security/security-assurance/security-compliance-commercial-and-dedicated/observation-management/-/issues/318

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Nick Nguyen

Merge request reports