Skip to content

Fix page javascript after a deploy token got created

Thomas Hutterer requested to merge 372132-project-deploy-token-create-js-import into master

What does this MR do and why?

Fixes #372132 (closed)

Screenshots or screen recordings

These screenshots show how the Mirroring Repositories section looks, after a deploy token got created. In the Before this MR shot you can see fewer input fields than in the After this MR shot. This is because before this MR, the Javascript for that section wasn't initialized.

There are probably other examples that wouldn't work in the Before this MR, but Mirroring Repositories is the one I initially noticed.

Before this MR After this MR
image image

How to set up and validate locally

  • Go to any project where you are owner.
  • Go to Settings/Repository (shortcut for your GDK: http://gdk.test:3000/flightjs/Flight/-/settings/repository#js-deploy-tokens)
  • In the Deploy tokens section, fill in the form and submit.
  • The same page gets rendered now with the token visible and a flash message.
  • Notice the different URL. It directly rendered HTML as response to your form's POST request to /-/settings/repository/deploy_token/create.
  • On this page, make sure all JS is functional as it was on the normal /-/settings/repository page.

🔁 Repeat the exact same procedure, but with your GDK running as CE:

gdk stop; export FOSS_ONLY=1; gdk start

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports