Skip to content

WIP: Update pipeline UI to accommodate post-merge pipelines

Nathan Friend requested to merge 7380-update-pipeline-ui into master

What does this MR do?

This MR makes a number of small changes to the current pipeline UI in order to support post-merge pipelines (gitlab-org/gitlab-ee#7380). The current pipeline UI looks like this:

Screenshot_from_2019-02-22_14-14-49

This MR makes the following changes:

  • In the case of a normal branch pipeline, there are no changes to the existing pipeline UI
  • In the case of a "detached" merge request pipeline:
    • The previously added merge request tag is removed
    • In its place, a detached tag is added
    • Instead of showing the branch name, the MR ID is shown with a link
  • In the case of a "merged result" merge request pipeline:
    • Same as above, except no detached tag

This information is sourced from the Pipeline list view section in the description of https://gitlab.com/gitlab-org/gitlab-ee/issues/7380#pipeline-list-view, which includes UI mockups showing each of the three scenarios above.

Assumptions

This frontend MR assumes the pipeline API has been updated to include a merge_request property as described here https://gitlab.com/gitlab-org/gitlab-ee/issues/7380#note_143891899:

"merge_request": {   // This hash is present only if the pipeline is for merge request
  "iid": integer,    // Show this iid at the ref name
  "path": string,    // Link to this path from the iid
  "title": string,   // Show tooltip when a cursor hovers the iid
  "source_branch": {
    "name": string,
    "path": string
  },
  "target_branch": {
    "name": string,
    "path": string
  }
}

What are the relevant issue numbers?

gitlab-org/gitlab-ee#7380

Does this MR meet the acceptance criteria?

Closes #7380 (closed)

Edited by Nathan Friend

Merge request reports