Fix: notify locale on removed milestone issue email
What does this MR do and why?
Reason
Right now the email template for removed milestone issue email notification can only be sent in English
Result
in this MR I updated the template with i18n enabled strings instead of hardcoded strings. After this MR it will be able to send languages the user prefers.
How to test locally
- Start your GDK instance locally or via gitpod or other ways
- Open the browser with your instance with path
gdk/rails/mailers/notify/removed_milestone_issue_email
- Observe.
/cc @prajnamas @orozot @qk44077907 @JeremyWuuuuu
Screenshots or screen recordings
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added JiHu contribution label
Hey @qt-gith!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @qt-gith
5 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. This Merge Request needs to be labelled with frontend, backend. Please request a reviewer or maintainer to add them. This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Zamir Martins Filho ( @zmartins
) (UTC+2)Aleksei Lipniagov ( @alipniagov
) (UTC+3)frontend Paul Gascou-Vaillancourt ( @pgascouvaillancourt
) (UTC-4)Paul Slaughter ( @pslaughter
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@bwill
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.
requested review from @bwill
mentioned in issue gitlab-org/quality/triage-reports#8947 (closed)
added Category:Internationalization emails labels
changed milestone to %15.4
Setting label(s) devopsmanage ~"group::import" sectiondev based on Category:Internationalization ~"group::import".
added devopsfoundations sectiondev + 1 deleted label
mentioned in issue gitlab-org/quality/triage-reports#8969 (closed)
added backend frontend maintenanceusability labels
added typemaintenance label
- Resolved by Aleksei Lipniagov
@qt-gith LGTM, although I think this change it small enough that it would have been better to do it in the same MR as !96624 (merged).
@alipniagov can you do the maintainer review please?
requested review from @alipniagov and removed review request for @bwill
- Resolved by qt
@bwill
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by 🤖 GitLab Bot 🤖
@bwill
, thanks for approving this merge request.This is the first time the merge request is approved. Please wait for AppSec approval.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
added sec-planningcomplete label
added maintenanceworkflow label and removed maintenanceusability label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Bojan Marjanović ( @bmarjanovic
) (UTC+2)Aleksei Lipniagov ( @alipniagov
) (UTC+3)frontend Sharmad Nachnolkar ( @snachnolkar
) (UTC+5.5)Paul Slaughter ( @pslaughter
) (UTC-5)~"codeowners" Reviewer review is optional for ~"codeowners" Marius Bobin ( @mbobin
) (UTC+3)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerenabled an automatic merge when the pipeline for 8856c362 succeeds
@qt-gith, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- Leave a
mentioned in commit 038e6844
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in issue gitlab-jh/status-reports#156
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added groupimport and integrate label and removed 1 deleted label