International Phone Input Vue component
What does this MR do and why?
- Creates a Vue component to let users enter their phone number with the international dial code.
- Creates a route and controller for the bigger epic https://gitlab.com/groups/gitlab-org/modelops/anti-abuse/-/epics/3
- Updates the
/-/countriesto include a flag and international dial code for the countries
Resolves https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/77
Screenshots or screen recordings
updated-international-phone-input
How to set up and validate locally
- Turn on SaaS mode with
export GITLAB_SIMULATE_SAAS=1- Turn on feature flag
bundle exec rails c
> Feature.enable(:identity_verification)- Sign in as a user and navigate to
http://localhost:3000/users/identity_verification
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to https://gitlab.com/gitlab-org/modelops/anti-abuse/team-tasks/-/issues/77
Merge request reports
Activity
assigned to @hmehra
- A deleted user
added backend feature flag frontend labels
2 Warnings 
This merge request is quite big (620 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Carla Drago ( @carlad-gl) (UTC+2, 8 hours behind@hmehra)Mayra Cabrera ( @mayra-cabrera) (UTC-5, 15 hours behind@hmehra)frontend Laura Meckley ( @lmeckley) (UTC-6, 16 hours behind@hmehra)Anna Vovchenko ( @anna_vovchenko) (UTC+3, 7 hours behind@hmehra)UX Matej Latin ( @matejlatin) (UTC+2, 8 hours behind@hmehra)Maintainer review is optional for UX ~"codeowners" Reviewer review is optional for ~"codeowners" Heinrich Lee Yu ( @engwan) (UTC+8, 2 hours behind@hmehra)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Resolved by 🤖 GitLab Bot 🤖Proper labels assigned to this merge request. Please ignore me.
1 Error, 1 Warning 
Please add typebug typefeature, or typemaintenance label to this merge request. Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Edited by 🤖 GitLab Bot 🤖
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1a01f8fb and 5b90a1bf
Entrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB -1.88 KB -0.1 % mainChunk 1.91 MB 1.91 MB - 0.0 % 
Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.users.identity_verification 0 Bytes 846.75 KB +846.75 KB 100.0 %
Note: We do not have exact data for 1a01f8fb. So we have used data from: 935a01a6.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!review-qa-blocking:
expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 12 | 48 | ❗ | | Create | 28 | 0 | 1 | 14 | 29 | ❗ | | Manage | 46 | 0 | 3 | 21 | 49 | ❗ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 61 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 320 | 0 | 10 | 4 | 330 | ❗ | | Verify | 94 | 0 | 8 | 4 | 102 | ❗ | | Manage | 200 | 0 | 6 | 36 | 206 | ❗ | | Plan | 114 | 0 | 0 | 0 | 114 | ✅ | | Fulfillment | 4 | 0 | 22 | 2 | 26 | ❗ | | Secure | 42 | 0 | 4 | 0 | 46 | ✅ | | Package | 0 | 0 | 6 | 0 | 6 | ➖ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 8 | 0 | 0 | 0 | 8 | ✅ | | Version sanity check | 0 | 0 | 2 | 0 | 2 | ➖ | | Protect | 4 | 0 | 0 | 0 | 4 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 790 | 0 | 64 | 46 | 854 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa-blocking:
expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 27 | 48 | ❗ | | Manage | 46 | 0 | 3 | 27 | 49 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 28 | 0 | 1 | 16 | 29 | ❗ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 84 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+- Resolved by Hinam Mehra
- Last reply by Hinam Mehra
added grouplicense label and removed devopssystems groupdistribution labels
changed milestone to %15.4
removed grouplicense label
removed Enterprise Edition label
removed direction label
removed marketing work label
removed GitLab Premium label
