Remove secure product metrics from usage_data.rb
What does this MR do and why?
A few Instrumentation classes were added with #339447 (closed)
We can remove the related code from usage_data.rb
and begin using the new framework
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
We have tests to verify that all the metrics with metric definitions are present in usage_data
.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #358148 (closed)
Merge request reports
Activity
changed milestone to %15.4
assigned to @nbelokolodov
added 1 commit
- 43127b3b - Move ci_ related metrics to instrumentation classes
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@psimyn
,@jivanvl
,@nick.thomas
,@rymai
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
1 Warning For the following files, a review from the Data team and Product Intelligence team is recommended
Please check the product intelligence Service Ping guide or the Snowplow guide.For MR review guidelines, see the Service Ping review guidelines or the Snowplow review guidelines.
ee/lib/ee/gitlab/usage_data.rb
ee/spec/lib/ee/gitlab/usage_data_spec.rb
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer product intelligence Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 2.5 hours behind@nbelokolodov
)Maintainer review is optional for product intelligence To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved [deprecated] Accepting merge requests label
added 1 commit
- 890cc3a6 - Move ci_ related metrics to instrumentation classes
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for ecbb7a25expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 11 | 29 | ❗ | | Plan | 47 | 0 | 1 | 11 | 48 | ❗ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Manage | 46 | 0 | 3 | 19 | 49 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Protect | 2 | 0 | 0 | 1 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 54 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa-blocking:
test report for ecbb7a25expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 41 | 48 | ❗ | | Create | 28 | 0 | 1 | 25 | 29 | ❗ | | Manage | 46 | 0 | 3 | 35 | 49 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 115 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Kerri Miller
@michold can you please review product intelligence?
requested review from @michold
- Resolved by Kerri Miller
@mcelicalderonG can you please review when convenient? backend
requested review from @mcelicalderonG
- Resolved by Kerri Miller
requested review from @euko
requested review from @mayra-cabrera and removed review request for @euko
requested review from @kerrizor and removed review request for @mcelicalderonG
removed database label
removed review request for @mayra-cabrera
removed databasereview pending label
@kerrizor
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @michold
enabled an automatic merge when the pipeline for 8d6c28d7 succeeds
mentioned in commit 4e3ea64f
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label