You need to sign in or sign up before continuing.
Migrate user_packages redis_hll metrics to instrumentation classes
requested to merge 368996-migrate-pending-redis_hll-metrics-to-instrumentation-classes-framework-a2f7e598053a2b5e into master
What does this MR do and why?
Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data
was used to collect all Redis HLL metrics data and add it to Service Ping payload. With new instrumentation classes framework there is new unified approach into adding metrics into Service Ping payload. This MR removes user_packages
metrics category from .unique_events_data and allows new framework automation to fill them in.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
pry(main)> Gitlab::UsageDataCounters::HLLRedisCounter.unique_events_data['user_packages']
=> nil
pry(main)> ServicePing::BuildPayload.new.execute[:redis_hll_counters]['user_packages']
=> {array of metrics}
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #368996 (closed)
Edited by Niko Belokolodov