Resolve "Limit Group Security Dashboard to selected types of vulnerabilities"
What does this MR do?
Limit all scopes for Group Security Dashboard to not show results from "hidden" report types
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ee/issues/9393
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Closes #9393 (closed)
Merge request reports
Activity
changed milestone to %11.9
added Deliverable backend devopssecure security dashboard + 1 deleted label
2 Warnings ⚠ The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge. ⚠ This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Reuben Pereira ( @rpereira2
)Nick Thomas ( @nick.thomas
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry added, if necessary as completed
added 2 commits
assigned to @brytannia
added 90 commits
-
a82339ec...b37f5b87 - 86 commits from branch
master
- cbd9326a - Add default reporty types scope
- d01d1aef - Fix failed tests
- 1e7243e7 - Add missed changelog
- 3068e2e2 - Fix style issues
Toggle commit list-
a82339ec...b37f5b87 - 86 commits from branch
assigned to @gonzoyumo
@brytannia that looks good to me as a temporary solution. Could you please add an issue to remove this code in something like
12.0
? As soon as we'll have all report type displayed in the Dashboard I think this code will be useless.And if we want to keep such feature on the long run I think we should have a different approach like a feature flag but I don't see a strong need for it.
@brodock could you please have a look?
assigned to @brodock
- Resolved by Kamil Trzciński
- Resolved by Kamil Trzciński
@brytannia Thanks, just a few questions :)
assigned to @brytannia
@gonzoyumo I've created an issue to remove this code in
12.0
https://gitlab.com/gitlab-org/gitlab-ee/issues/10048@brodock I've answered your questions and changed a test message. Back to you!
assigned to @brodock
mentioned in issue #8482 (closed)
assigned to @brytannia
@brytannia one last thing. After you decide/address it you can send to a maintainer
@ayufan could you please review this MR? I've addressed Gabriel's comments and I'm assigning this MR to maintainer review as he suggested.
assigned to @ayufan
- Resolved by Kamil Trzciński
- Resolved by Kamil Trzciński
assigned to @brytannia
@brytannia WDYT about my proposal?
@ayufan please see my answer in the discussion. https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9626#note_145951053
assigned to @ayufan
added typebug label
assigned to @brytannia
assigned to @ayufan
We don't really use
abbreviations
in code, so something likefparams
it is not nice. We prefer to use full names, everywhere. I made this change on my own, to not block it from merging: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9626/diffs?commit_id=d900e31066d5a4ead97e1a98238f9006b95b91eeApproved. Clicked MWPS
❤ But I also saw some test failing, and you may need to rebase it :)marked the checklist item Tested in all supported browsers as completed
marked the checklist item Conforms to the code review guidelines as completed
marked the checklist item Tested in all supported browsers as incomplete
marked the checklist item Conforms to the merge request performance guidelines as completed
marked the checklist item Conforms to the style guides as completed
enabled an automatic merge when the pipeline for d900e310 succeeds
assigned to @brytannia