Skip to content
Snippets Groups Projects

Resolve "Limit Group Security Dashboard to selected types of vulnerabilities"

Merged Tetiana Chupryna requested to merge 9393-limit-report-types-for-group-sec into master

What does this MR do?

Limit all scopes for Group Security Dashboard to not show results from "hidden" report types

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/9393

Does this MR meet the acceptance criteria?

Closes #9393 (closed)

Edited by Kamil Trzciński

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Gabriel Mazetto
  • @brytannia Thanks, just a few questions :)

  • @gonzoyumo I've created an issue to remove this code in 12.0 https://gitlab.com/gitlab-org/gitlab-ee/issues/10048

  • added 1 commit

    • c909e6c4 - Make test message more explicit

    Compare with previous version

  • @brodock I've answered your questions and changed a test message. Back to you!

  • mentioned in issue #8482 (closed)

  • @brytannia one last thing. After you decide/address it you can send to a maintainer

  • added 1 commit

    Compare with previous version

  • @ayufan could you please review this MR? I've addressed Gabriel's comments and I'm assigning this MR to maintainer review as he suggested.

  • assigned to @ayufan

  • @brytannia WDYT about my proposal?

  • assigned to @ayufan

  • added typebug label

  • added 1 commit

    • 58654799 - Simplify reports param condition

    Compare with previous version

  • assigned to @ayufan

  • Kamil Trzciński resolved all discussions

    resolved all discussions

  • added 1 commit

    • d900e310 - Rename `fparams` to `filter_params`

    Compare with previous version

  • @brytannia

    We don't really use abbreviations in code, so something like fparams it is not nice. We prefer to use full names, everywhere. I made this change on my own, to not block it from merging: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9626/diffs?commit_id=d900e31066d5a4ead97e1a98238f9006b95b91ee

    Approved. Clicked MWPS But I also saw some test failing, and you may need to rebase it :)

  • Kamil Trzciński marked the checklist item Tested in all supported browsers as completed

    marked the checklist item Tested in all supported browsers as completed

  • Kamil Trzciński marked the checklist item Conforms to the code review guidelines as completed

    marked the checklist item Conforms to the code review guidelines as completed

  • Kamil Trzciński marked the checklist item Tested in all supported browsers as incomplete

    marked the checklist item Tested in all supported browsers as incomplete

  • Kamil Trzciński marked the checklist item Conforms to the merge request performance guidelines as completed

    marked the checklist item Conforms to the merge request performance guidelines as completed

  • Kamil Trzciński marked the checklist item Conforms to the style guides as completed

    marked the checklist item Conforms to the style guides as completed

  • Kamil Trzciński marked the checklist item For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? as completed

    marked the checklist item For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? as completed

  • Kamil Trzciński marked the checklist item EE specific content should be in the top level /ee folder as completed

    marked the checklist item EE specific content should be in the top level /ee folder as completed

  • Kamil Trzciński marked the checklist item Security reports checked/validated by reviewer as completed

    marked the checklist item Security reports checked/validated by reviewer as completed

  • Kamil Trzciński enabled an automatic merge when the pipeline for d900e310 succeeds

    enabled an automatic merge when the pipeline for d900e310 succeeds

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading