Skip to content

Fix error alert on contact list

Lee Tickett requested to merge 2256-fix-error-dismiss-bug into master

What does this MR do and why?

We are not properly leveraging PaginatedTableWithSearchAndTabs error surfacing/encapsulation in the CRM contact and organization lists.

This MR addresses that.

Screenshots or screen recordings

Before

Screenshot_2022-09-20_at_09.00.26

After

Screenshot_2022-09-20_at_08.59.50

How to set up and validate locally

  1. Enable CRM for a group: https://docs.gitlab.com/ee/user/crm/#enable-customer-relations-management-crm
  2. Visit the contact/organization list for that group: https://docs.gitlab.com/ee/user/crm/#contacts
  3. Using your browser's developer tools, block access to gdk.test:3000/api/graphql
  4. Reload the page
  5. Ensure the red alert appears at the top of the page (and is dismissable)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #2256

Edited by Lee Tickett

Merge request reports