Rename can_be_approved_by? to be more descriptive (!96224) · Merge requests · GitLab.org / GitLab

Sincheol (David) Kim requested to merge 366529-approvable-check-refactor into master Aug 25, 2022

What does this MR do and why?

can_be_approved_by? can be confusing since we have a policy check called :approve_merge_request and it can be called like user.can?(:approve_merge_request, merge_request, user) This is an attempt to make it more clear how this method is different from that policy check.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

I have evaluated the MR acceptance checklist for this MR.

Related to #366529 (closed)

Edited Aug 25, 2022 by Sincheol (David) Kim

Rename can_be_approved_by? to be more descriptive

What does this MR do and why?

MR acceptance checklist

Merge request reports