Skip to content

Fix dropdown in CI/CD variables not showing the current type

Frédéric Caplette requested to merge fc-fix-variable-dropdown into master

What does this MR do and why?

We were using the wrong constants in the new CI/CD variable dropdown which resulted in the currently selected type not to be shown. This commit now make use of the right constant.

Screenshots or screen recordings

Before After
Screen_Shot_2022-08-23_at_9.17.14_AM Screen_Shot_2022-08-23_at_9.16.57_AM

How to set up and validate locally

  1. Enable the feature flag
Feature.enable(:ci_variable_settings_graphql)
  1. Visit /$user/$Project/-/settings/ci_cd
  2. Add a variable
  3. Select a type (example, File)
  4. Save the variable
  5. Click to edit the variable
  6. Notice the selected type is shown

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports