Fix Layout/HashAlignment offenses 34
What does this MR do and why?
Part of #239356.
Resolve Layout/HashAlignment
rubocop offenses; part 34.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #239356
Merge request reports
Activity
changed milestone to %Backlog
assigned to @thiagocsf
changed milestone to %15.4
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mayra-cabrera
,@rspeicher
,@rymai
,@ayufan
,@stanhu
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning 93077729: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aman Luthra ( @aluthra2
) (UTC+5.5, 4.5 hours behind@thiagocsf
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 13 hours behind@thiagocsf
)~"Compliance" Reviewer review is optional for ~"Compliance" Harsimar Sandhu ( @harsimarsandhu
) (UTC+5.5, 4.5 hours behind@thiagocsf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Douglas Barbosa Alexandre
@aluthra2, can I please get a backend review?
@harsimarsandhu, can you please approve from a groupcompliance perspective?
requested review from @harsimarsandhu and @aluthra2
- Resolved by Aman Luthra
@aluthra2
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Douglas Barbosa Alexandre
@dbalexandre - Can you please help with the maintainer review and merge of this MR? TIA.
requested review from @dbalexandre
removed review request for @aluthra2
1 Warning c9008ad4: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aman Luthra ( @aluthra2
) (UTC+5.5, 4.5 hours behind@thiagocsf
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 13 hours behind@thiagocsf
)~"Compliance" Reviewer review is optional for ~"Compliance" Huzaifa Iftikhar ( @huzaifaiftikhar1
) (UTC+5.5, 4.5 hours behind@thiagocsf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved review request for @dbalexandre
added 153 commits
-
93077729...06bd77d0 - 152 commits from branch
master
- 2c998470 - Fix Layout/HashAlignment offenses
-
93077729...06bd77d0 - 152 commits from branch
requested review from @dbalexandre
enabled an automatic merge when the pipeline for b68e550c succeeds
Thanks, @thiagocsf! MWPS set
added 22 commits
-
2c998470...fdf254d2 - 21 commits from branch
master
- b5cd6b91 - Fix Layout/HashAlignment offenses
-
2c998470...fdf254d2 - 21 commits from branch
- Resolved by Thiago Figueiró
I've tested the failing spec locally and it passed
Rebasing for now in case it's a failure on
master
.Edited by Thiago Figueiró
mentioned in merge request !96111 (merged)
removed review request for @harsimarsandhu
added 116 commits
-
b5cd6b91...f431c306 - 115 commits from branch
master
- c9008ad4 - Fix Layout/HashAlignment offenses
-
b5cd6b91...f431c306 - 115 commits from branch
enabled an automatic merge when the pipeline for 63997366 succeeds
mentioned in commit 3c411f49
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label