Broadly restrict downstream pipeline tree size
https://gitlab.com/gitlab-org/gitlab/-/issues/358075
Four Merge Requests to addressStep | Merge Request | |
---|---|---|
1 | !95753 (merged) Rename pipeline hierarchy methods | |
2 | !95756 (merged) Report full size of Ci::Pipeline hierarchy trees | |
3 | !95857 (merged) Broadly restrict downstream pipeline tree size |
|
4 | !97841 (merged) Enable pipeline hierarchy size limit by default |
What does this MR do and why?
Until now, we've only counted downstream pipelines within the same project against MAX_NESTED_CHILDREN. With this change, we'll now consider the entire queryable pipeline tree, including different branches off the same ancestor.
How to set up and validate locally
- Review the new method
complete_hierarchy_count
and the associated specs for it. - Given the specified behavior, see how we've added a check for it in the
CreateDownstreamPipelineService
. - Make sure the specs pass.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by drew stachon