Skip to content

Fix flaky SSH remote mirror spec

Stan Hu requested to merge sh-fix-flaky-spec into master

What does this MR do and why?

This failed in https://gitlab.com/gitlab-org/gitlab/-/jobs/2905098518, likely needing the same fix in !92178 (merged).

The test was failing intermittently because the test would input the URL and submit the data faster than the JavaScript was able to update the internal field. This caused a blank URL to be submitted on occasion. To make this spec more reliable, we now ensure the hidden URL field is updated with the right value before clicking the "Save changes" button.

Relates to #337394 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports