NotifyServices to inherit from BaseProjectService
What does this MR do and why?
This MR is only a refactor. It contains no functional or user-facing changes.
Service classes should inherit from one of BaseProjectService
/BaseGroupService
/BaseContainerService
. This MR migrates app/services/projects/alerting/notify_service.rb
& app/services/projects/prometheus/alerts/notify_service.rb
to inherit from BaseProjectService
.
Context: I'm doing a pretty big rewrite in this area of the codebase for https://gitlab.com/gitlab-org/gitlab/-/issues/348676, and I'm trying to break out as much as I can from that diff.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Sarah Yasonik