Conclude the combined registration experiment
What does this MR do and why?
- conclude the
combined_registration
experiment as described in #350754 with candidate being the winner- removes all
control
code, which means thegroups
andprojects
controllers in registrations are no longer used and therefore removes all code for that and items related to it.
- removes all
- resolve rubocop todos for
combined_registration
items - converts experiment tracking to regular tracking
note
- this feature flag has been fully enabled on
.com
for months now. - group/project creation flow only occurs on
.com
due to this method which is called from show_signup_onboarding? which causes update_success_path to be invoked via this area - my comments are best viewed from the file(changes tab)
Screenshots or screen recordings
promoted existing combined group/project creation in the registration flow
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Enable https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart GDK
- Register as a new user
- Select a role
- Just me
- Create a new project
- Observe form/complete it
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #350754
Edited by Doug Stull