Skip to content

Improve the performance of bubble menus in the Content Editor

Enrique Alcántararequested to merge
369020-bubble-menu-wrapper into master

What does this MR do and why?

It improves the performance of mounting the Content Editor component by implementing a more efficient Bubble Menu component. These are the performance metrics before/after the change:

Before After
Screen_Shot_2022-08-18_at_1.47.19_PM Screen_Shot_2022-08-18_at_1.48.15_PM
576.7ms 132.6ms

The new bubble menu component is more efficient because it doesn’t mount children components if the bubble menu isn’t visible.

Screenshots or screen recordings

This MR doesn’t introduce user-facing changes.

How to set up and validate locally

  1. Create or update a Wiki page in your local environment.
  2. Switch to "Rich text" mode.
  3. Write some text, create a link, insert an image, and insert a code block.
  4. Use the bubble menus for all four these elements. They should work correctly.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #369020 (closed)

Edited by Enrique Alcántara

Merge request reports