Fix bug when non active participant is rendered
What does this MR do and why?
Describe in detail what your merge request does and why.
Fixes bug in rendering oncall schedule rotation when participant is no longer active, introduced in !90497 (merged).
Testing will be added urgently via this issue #371217 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Open a project where you are at least a maintainer and at least Premium is activated
- On the left menu bar select Monitor->On-Call Schedules
- Add a schedule
- Add a rotation with at least 2 participants
- Allow for time to pass so that the shift occurs in the past.
- Remove a participant from the rotation Since you cannot wait for time to pass, this is not possible, you can change ee/app/assets/javascripts/oncall_schedules/components/schedule/components/shifts/components/schedule_shift_wrapper.vue#L43 to
[].forEach(({ id }, index) => {
This will make all participants no longer active participants
- reload oncall schedules page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by James Rushford