Update Runner UI badges
What does this MR do and why?
This change updates runner UI badges to use more relevant icons and colors, as well as updated labels.
This change is part of #343133 (closed), and it's complemented by a change in the layout at !95617 (merged), but it's issued separately.
Screenshots or screen recordings
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Changes are visible in the Admin -> Runners area and Group -> Runners
- Visit Admin -> Runners
- Check the layout with then new badges
- Select any runner
- Check the layout with then new badges
- Visit any group -> CI/CD -> Runners
- Check the layout with then new badges
- Select any runner
- Check the layout with then new badges
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #343133 (closed)
Merge request reports
Activity
changed milestone to %15.4
- A deleted user
added frontend label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3ab70792 and 39ed0298
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.6 MB 3.6 MB - 0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 %
Note: We do not have exact data for 3ab70792. So we have used data from: 254443d3.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 9e7b4115expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 6 | 29 | ❗ | | Plan | 47 | 0 | 1 | 1 | 48 | ❗ | | Manage | 46 | 0 | 3 | 14 | 49 | ❗ | | Verify | 12 | 0 | 1 | 5 | 13 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 1 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 29 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa-blocking:
test report for c5f76e3dexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 57 | 0 | 3 | 31 | 60 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Plan | 47 | 0 | 1 | 30 | 48 | ❗ | | Create | 28 | 0 | 1 | 16 | 29 | ❗ | | Verify | 12 | 0 | 1 | 10 | 13 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 157 | 0 | 9 | 91 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 91 commits
-
bd34f686...96065d6f - 90 commits from branch
master
- 114beab8 - Update Runner UI badges
-
bd34f686...96065d6f - 90 commits from branch
removed workflowready for development label
removed Technical Writing label
removed UI text label
added 71 commits
-
114beab8...3ab70792 - 70 commits from branch
master
- 39ed0298 - Update Runner UI badges
-
114beab8...3ab70792 - 70 commits from branch
assigned to @mrincon
mentioned in issue #343133 (closed)
- Resolved by Miguel Rincon
added 1022 commits
-
39ed0298...83ef92f9 - 1021 commits from branch
master
- 8601afdf - Update Runner UI badges
-
39ed0298...83ef92f9 - 1021 commits from branch
6 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.5fec5f28: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 41f3ee94: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 45b2cdee: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains deprecated components. Please consider using Pajamas components instead. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- .tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Fernando Arias ( @farias-gl
) (UTC+2, same timezone as@mrincon
)Anna Vovchenko ( @anna_vovchenko
) (UTC+3, 1 hour ahead of@mrincon
)test for spec/features/*
Aleksandr Lyubenkov ( @alyubenkov
) (UTC+2, same timezone as@mrincon
)Maintainer review is optional for test for spec/features/*
UX Sascha Eggenberger ( @seggenberger
) (UTC+2, same timezone as@mrincon
)Maintainer review is optional for UX ~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Drew Blessing ( @dblessing
) (UTC-5, 7 hours behind@mrincon
)~"codeowners" Reviewer review is optional for ~"codeowners" Andrejs Cunskis ( @acunskis
) (UTC+2, same timezone as@mrincon
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed design-weight2 label
@emilybauman can you help me review this UX change? Thanks!
Edited by Miguel Rinconrequested review from @emilybauman
- Resolved by Miguel Rincon
@eduardosanz can you help me with a review of this frontend change? I would like to assign to
@markrian
for some context ongl-badge
.Edited by Miguel Rincon
requested review from @eduardosanz
- Resolved by Miguel Rincon
requested review from @cwiesner
- Resolved by Miguel Rincon
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 0f6fce38 and d79b121d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.51 MB 3.51 MB - 0.0 % mainChunk 1.91 MB 1.91 MB - 0.0 %
Note: We do not have exact data for 0f6fce38. So we have used data from: b70d5d7a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 7 commits
-
8601afdf...07ebdbd5 - 6 commits from branch
master
- 9e7b4115 - Update Runner UI badges
-
8601afdf...07ebdbd5 - 6 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @gdoyle
,@iamphill
,@vitallium
,@pedropombeiro
,@rhardarson
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in merge request !95617 (merged)
removed review request for @cwiesner
mentioned in merge request gitlab-ui!2990 (closed)
- Resolved by Gina Doyle
Hey @mrincon - Thanks for the tag here!
I've checked this and the new UI Badges are showing up as expected! I'll go ahead and give my approval.
Non-Blocking: The upgrade recommended icon in the Runner Detail page seems to be touching the top and bottom of the badge. I couldn't find the proposed design for this in the connected issue so wanted to check if it is showing as expected @gdoyle.
Screenshot
removed review request for @emilybauman
@emilybauman
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
@mrincon, great work! I found the MR to be a bit too large.
for changing the lowercase version of the labels toSentence case
and to use i18n constants.I have left a few comments for your consideration. Back to you
.added 394 commits
-
9e7b4115...a4bc507d - 392 commits from branch
master
- 12016d40 - Update Runner UI badges
- e81e0d93 - Address reviewer comments
-
9e7b4115...a4bc507d - 392 commits from branch
- Resolved by Ezekiel Kigbo
Great job, @mrincon! I approve the MR.
Please, @slashmanov, could you do the frontend review? Thanks.
requested review from @slashmanov and removed review request for @eduardosanz
- Resolved by Miguel Rincon
@mrincon, it seems there are some failing tests: https://gitlab.com/gitlab-org/gitlab/-/jobs/2959813670
added 189 commits
-
e81e0d93...98d8e33e - 186 commits from branch
master
- ad919355 - Update Runner UI badges
- 4ea6e65b - Address reviewer comments
- c5f76e3d - Update tests from rebase
Toggle commit list-
e81e0d93...98d8e33e - 186 commits from branch
requested review from @ekigbo and removed review request for @slashmanov
- Resolved by Miguel Rincon
requested review from @alyubenkov
removed review request for @alyubenkov
requested review from @emilybauman
requested review from @alyubenkov
removed review request for @alyubenkov
removed review request for @emilybauman
added 266 commits
-
c5f76e3d...4c75c1f2 - 262 commits from branch
master
- 2db3814d - Update Runner UI badges
- d8c72cb8 - Address reviewer comments
- 04bf42ad - Update tests from rebase
- fc4df85a - Move "Paused" translation to constants
Toggle commit list-
c5f76e3d...4c75c1f2 - 262 commits from branch
added pipeline:run-all-jest label
removed pipeline:run-all-jest label
added pipeline:run-as-if-foss label
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
enabled an automatic merge when the pipeline for d782c069 succeeds
mentioned in commit bfd5f7ca
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
50 50 51 51 it 'shows an instance badge' do 52 52 within_runner_row(instance_runner.id) do 53 expect(page).to have_selector '.badge', text: 'shared' 53 expect(page).to have_selector '.badge', text: 'Instance' @mrincon, we missed this one:
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !97367 (merged)
mentioned in issue gitlab-ui#1950 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1453 (merged)
added releasedpublished label and removed releasedcandidate label