Skip to content
Snippets Groups Projects

Update Runner UI badges

Merged Miguel Rincon requested to merge 343133-update-runner-badges into master
1 unresolved thread

What does this MR do and why?

This change updates runner UI badges to use more relevant icons and colors, as well as updated labels.

This change is part of #343133 (closed), and it's complemented by a change in the layout at !95617 (merged), but it's issued separately.

Screenshots or screen recordings

before after
image image
image image

How to set up and validate locally

Changes are visible in the Admin -> Runners area and Group -> Runners

  1. Visit Admin -> Runners
  2. Check the layout with then new badges
  3. Select any runner
  4. Check the layout with then new badges

  1. Visit any group -> CI/CD -> Runners
  2. Check the layout with then new badges
  3. Select any runner
  4. Check the layout with then new badges

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #343133 (closed)

Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Miguel Rincon added 1022 commits

    added 1022 commits

    Compare with previous version

  • 6 Warnings
    :warning: This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.
    :warning: 5fec5f28: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
    :warning: 41f3ee94: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: 45b2cdee: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    :warning: This merge request contains deprecated components. Please consider using Pajamas components instead.

    Deprecated components

    These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.

    • .tooltip

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Fernando Arias (@farias-gl) (UTC+2, same timezone as @mrincon) Anna Vovchenko (@anna_vovchenko) (UTC+3, 1 hour ahead of @mrincon)
    test for spec/features/* Aleksandr Lyubenkov (@alyubenkov) (UTC+2, same timezone as @mrincon) Maintainer review is optional for test for spec/features/*
    UX Sascha Eggenberger (@seggenberger) (UTC+2, same timezone as @mrincon) Maintainer review is optional for UX
    ~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Drew Blessing (@dblessing) (UTC-5, 7 hours behind @mrincon)
    ~"codeowners" Reviewer review is optional for ~"codeowners" Andrejs Cunskis (@acunskis) (UTC+2, same timezone as @mrincon)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Miguel Rincon marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Miguel Rincon changed the description

    changed the description

  • Author Maintainer

    @emilybauman can you help me review this UX change? Thanks!

    Edited by Miguel Rincon
  • Miguel Rincon requested review from @emilybauman

    requested review from @emilybauman

  • Miguel Rincon requested review from @eduardosanz

    requested review from @eduardosanz

  • Miguel Rincon requested review from @cwiesner

    requested review from @cwiesner

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 0f6fce38 and d79b121d

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.51 MB 3.51 MB - 0.0 %
    mainChunk 1.91 MB 1.91 MB - 0.0 %

    Note: We do not have exact data for 0f6fce38. So we have used data from: b70d5d7a.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Miguel Rincon marked this merge request as ready

    marked this merge request as ready

  • Miguel Rincon added 7 commits

    added 7 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @gdoyle, @iamphill, @vitallium, @pedropombeiro, @rhardarson

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

    Edited by GitLab Reviewer-Recommender Bot
  • Miguel Rincon mentioned in merge request !95617 (merged)

    mentioned in merge request !95617 (merged)

  • Corinna Gogolok removed review request for @cwiesner

    removed review request for @cwiesner

  • mentioned in merge request gitlab-ui!2990 (closed)

    • Resolved by Gina Doyle

      Hey @mrincon - Thanks for the tag here!

      I've checked this and the new UI Badges are showing up as expected! I'll go ahead and give my approval.

      Non-Blocking: The upgrade recommended icon in the Runner Detail page seems to be touching the top and bottom of the badge. I couldn't find the proposed design for this in the connected issue so wanted to check if it is showing as expected @gdoyle.

      Screenshot
      Screen_Shot_2022-08-29_at_6.50.33_PM
  • Emily Bauman approved this merge request

    approved this merge request

  • Emily Bauman removed review request for @emilybauman

    removed review request for @emilybauman

  • :wave: @emilybauman, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Eduardo Sanz García
  • Eduardo Sanz García
  • Eduardo Sanz García
  • @mrincon, great work! I found the MR to be a bit too large.

    :clap: for changing the lowercase version of the labels to Sentence case and to use i18n constants.

    I have left a few comments for your consideration. Back to you :ping_pong:.

  • Miguel Rincon added 394 commits

    added 394 commits

    Compare with previous version

  • Eduardo Sanz García approved this merge request

    approved this merge request

  • Eduardo Sanz García requested review from @slashmanov and removed review request for @eduardosanz

    requested review from @slashmanov and removed review request for @eduardosanz

  • Miguel Rincon added 189 commits

    added 189 commits

    Compare with previous version

  • Miguel Rincon requested review from @ekigbo and removed review request for @slashmanov

    requested review from @ekigbo and removed review request for @slashmanov

  • Ezekiel Kigbo
  • Ezekiel Kigbo requested review from @alyubenkov

    requested review from @alyubenkov

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon removed review request for @alyubenkov

    removed review request for @alyubenkov

  • Miguel Rincon requested review from @emilybauman

    requested review from @emilybauman

  • Miguel Rincon requested review from @alyubenkov

    requested review from @alyubenkov

  • Aleksandr Lyubenkov approved this merge request

    approved this merge request

  • Aleksandr Lyubenkov removed review request for @alyubenkov

    removed review request for @alyubenkov

  • Emily Bauman removed review request for @emilybauman

    removed review request for @emilybauman

  • Miguel Rincon added 266 commits

    added 266 commits

    Compare with previous version

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Miguel Rincon added 64 commits

    added 64 commits

    Compare with previous version

  • Miguel Rincon added 1 commit

    added 1 commit

    • d79b121d - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for d782c069 succeeds

    enabled an automatic merge when the pipeline for d782c069 succeeds

  • merged

  • Ezekiel Kigbo mentioned in commit bfd5f7ca

    mentioned in commit bfd5f7ca

  • Miguel Rincon changed the description

    changed the description

  • 50 50
    51 51 it 'shows an instance badge' do
    52 52 within_runner_row(instance_runner.id) do
    53 expect(page).to have_selector '.badge', text: 'shared'
    53 expect(page).to have_selector '.badge', text: 'Instance'
  • added workflowstaging label and removed workflowcanary label

  • Miguel Rincon mentioned in merge request !97367 (merged)

    mentioned in merge request !97367 (merged)

  • Please register or sign in to reply
    Loading