Skip to content

Remove additional classes on GLTokenSelector

James Rushford requested to merge 344950-fix-UX-bugs-in-add-rotation into master

What does this MR do and why?

Describe in detail what your merge request does and why.

As per this comment, to remove the visual issue of vertical alignment, the decision was to remove to the fixed height of this GlTokenSelector. Once the fixed height is removed, the gl-overflow-y-auto is no longer relevant either.

Also removing gl-overflow-y-auto in menu classes as it is automatically added within GlTokenSelector.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

before after
Screen_Shot_2022-08-18_at_14.33.03 Screen_Shot_2022-08-18_at_14.21.25
Screen_Shot_2022-08-18_at_14.33.39 Screen_Shot_2022-08-18_at_14.21.39
Screen_Shot_2022-08-18_at_14.32.45 Screen_Shot_2022-08-18_at_14.19.54

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #344950 (closed)

Edited by James Rushford

Merge request reports