Skip to content

Place learn gitlab creation in background on user registration

Doug Stull requested to merge 370525-remediate-slowness-in-groupsprojectscontroller into master

What does this MR do and why?

  • measures current query count(still over) by including some request level specs.
  • places learn gitlab creation into a worker in the background.

Why? - see #370525 (closed) as we attempt to fix an error budget issue with the create action on the GroupsProjectsController

How to set up and validate locally

note basically trying to emulate feature spec steps in https://gitlab.com/gitlab-org/gitlab/blob/1fa4f2ac8a80567b5ddde10bc42e180771df823a/ee/spec/features/registrations/saas_user_registration_spec.rb#L231-231

  1. Simulate SaaS - https://docs.gitlab.com/ee/development/ee_features.html#simulate-a-saas-instance and restart gdk
  2. Enable combined_registration feature flag in rails console Feature.enable(:combined_registration)
  3. Register as a new user.
  4. Select 'Just me' in the welcome form after sign up step.
  5. Choose 'Create a new project'
  6. Click 'Continue'
  7. Fill out fields to create a group and project on the next page.
  8. Click 'Create project'
  9. Verify you get to the onboarding flow and page refreshes to provide a "Ok, let's go" button.
  10. Click on "Ok, let's go" and verify you are dropped into the learn gitlab project

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #370525 (closed)

Edited by Doug Stull

Merge request reports