Skip to content

Update Sketch Preview Data fetching

Lukas 'ai-pi' Eipert requested to merge leipert-update-jszip into master

What does this MR do and why?

Update Sketch Preview Data fetching

This replaces the dependency jszip-utils with axios, as the former is mainly used for some data fetching. All the cases it seems to handle (e.g. some quirks for older versions of Internet Explorer) we do not really care about and therefore we can just replace it with axios.

Also reworked the loading logic a little to be more readable.

Update jszip dependency

This updates the jszip dependency we use for rendering sketch files in the blob viewer. Nothing major changes for us, we just bump the version.

Screenshots or screen recordings

Before After
before-borked after-borked
before-okay after-okay

How to set up and validate locally

You can use the files from gitlab-test!57 to preview locally. Note: Preview doesn't work in MR views, it has to be the Repo view

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports