Skip to content

Fix nil DORA values in Insights

Adam Hegyi requested to merge fix-nil-dora-values-in-insights into master

What does this MR do and why?

This PR fixes the broken DORA chart when some metrics return nil values (lead time for changes, time to restore service): https://gitlab.com/groups/gitlab-org/-/insights/#/dora

The chart will render a gap when nil values are found.

Exception on PRD:

ee/lib/gitlab/insights/reducers/dora_reducer.rb:41:in `format_value', ee/lib/gitlab/insights/reducers/dora_reducer.rb:15:in `block in reduce', ee/lib/gitlab/insights/reducers/dora_reducer.rb:14:in `reverse_each', ee/lib/gitlab/insights/reducers/dora_reducer.rb:14:in `each_with_object', ee/lib/gitlab/insights/reducers/dora_reducer.rb:14:in `reduce', ee/lib/gitlab/insights/reducers/base_reducer.rb:10:in `reduce', ee/lib/gitlab/insights/executors/dora_executor.rb:26:in `execute', ee/lib/gitlab/insights/loader.rb:29:in `execute', ee/app/controllers/concerns/insights_actions.rb:32:in `block (2 levels) in query', ee/app/controllers/concerns/insights_actions.rb:26:in `query', ee/lib/gi

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports