Skip to content

Restore label on the email field

Paul Gascou-Vaillancourt requested to merge new-password-restore-label into master

What does this MR do and why?

This restores the label on the email field in the new password page. The label was accidentally removed while redesigning the sign-in flow behind the :restyle_login_page feature flag. A condition was added to add a CSS utility when the flag is enabled, but the condition extended to the whole label's rendering. This fixes it by scoping the condition to the class option only.

Screenshots or screen recordings

Before After
:restyle_login_page disabled Screen_Shot_2022-08-15_at_2.33.45_PM Screen_Shot_2022-08-15_at_2.32.18_PM
:restyle_login_page enabled Screen_Shot_2022-08-15_at_2.32.34_PM Screen_Shot_2022-08-15_at_2.32.34_PM

How to set up and validate locally

  1. Enable or disable the feature flag depending on what version of the changes you'd like to verify.
# Disable the flag
Feature.disable(:restyle_login_page)

# Or enable it
Feature.enable(:restyle_login_page)
  1. Sign out of your GDK.
  2. On the sign-in page, click on Forgot your password?.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports