Skip to content

Return configuration for OpenID Connect provider with custom name

Viz requested to merge vizv/gitlab:fix-oidc-icon-label into master

What does this MR do and why?

Currently OpenID Connect OmniAuth configuration doesn't display icon and label unless the provider name is openid_connect, this MR enables icon and label display for OIDC provider with custom name such as visa_sso.

Screenshots or screen recordings

gitlab.rb:

...
gitlab_rails['omniauth_providers'] = [
  {
    'name' => 'openid_connect',
    'label' => 'Visa SSO',
    'icon' => 'https://***/favicon.svg',
    'args' => {
      'name' => 'visa_sso',
...

gitlab-odic-before

How to set up and validate locally

Apply my patch, and restart puma server with gitlab-ctl,

gitlab-odic-after

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Viz

Merge request reports