Refactor timeline event list
What does this MR do and why?
Describe in detail what your merge request does and why.
In order to allow that addition of edit functionality in timeline events as in #344060 (closed), the timeline event list must be refactored so that app/assets/javascripts/issues/show/components/incidents/timeline_events_form.vue
can be used within the list.
No visual changes, only refactoring
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added maintenancerefactor typemaintenance labels
assigned to @jrushford
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @alyubenkov
,@rkadam3
,@ntepluhina
,@agarciatesares
,@vitallium
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added frontend label
1 Warning dac0cd32: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Axel García ( @agarciatesares
) (UTC-4, 6 hours behind@jrushford
)Andrew Fontaine ( @afontaine
) (UTC-4, 6 hours behind@jrushford
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 83fc59ee and b206f705
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.5 MB 3.5 MB - -0.0 % mainChunk 1.9 MB 1.9 MB - 0.0 %
Note: We do not have exact data for 83fc59ee. So we have used data from: a82efcb5.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @dzubova
- Resolved by James Rushford
- Resolved by James Rushford
- Resolved by Ezekiel Kigbo
@jrushford thanks for the refactoring, could you please point to the follow-up MR where you are planning to add more elements to the list? Just that we don't miss the context and could see the planned usage.
Also, I assume this is supposed to be %15.3 ;)
changed milestone to %15.3
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for b206f705expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 46 | 0 | 3 | 39 | 49 | ❗ | | Create | 28 | 0 | 1 | 28 | 29 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 9 | 139 | 155 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
@dzubova
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Setting label grouprespond based on
@jrushford
's group.added grouprespond label
added 114 commits
-
114b45c1...3a1b92da - 113 commits from branch
master
- cd928c9b - Move timeline event li element to timeline list
-
114b45c1...3a1b92da - 113 commits from branch
Setting label(s) devopsmonitor sectionops based on grouprespond.
added devopsmonitor sectionops labels
- Resolved by Tristan Read
- Resolved by Tristan Read
assigned to @tristan.read
mentioned in merge request !93545 (merged)
mentioned in merge request !94899 (merged)
added 867 commits
-
23e519ab...33a3c9d5 - 864 commits from branch
master
- 6b1a0891 - Move timeline event li element to timeline list
- dac0cd32 - Address review comments
- b206f705 - Add button component
Toggle commit list-
23e519ab...33a3c9d5 - 864 commits from branch
enabled an automatic merge when the pipeline for 39ab7530 succeeds
mentioned in commit dd430d92
mentioned in merge request !95061 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
mentioned in merge request !95046 (merged)
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !95638 (merged)
mentioned in commit c530a80c
mentioned in commit 510b2d96
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue customers-gitlab-com#3984 (closed)