Skip to content
Snippets Groups Projects

Refactor timeline event list

Merged James Rushford requested to merge refactor-timeline-event-list-item into master
All threads resolved!

What does this MR do and why?

Describe in detail what your merge request does and why.

In order to allow that addition of edit functionality in timeline events as in #344060 (closed), the timeline event list must be refactored so that app/assets/javascripts/issues/show/components/incidents/timeline_events_form.vue can be used within the list.

No visual changes, only refactoring

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Ezekiel Kigbo

      @jrushford thanks for the refactoring, could you please point to the follow-up MR where you are planning to add more elements to the list? Just that we don't miss the context and could see the planned usage.

      Also, I assume this is supposed to be %15.3 ;)

  • Diana Zubova changed milestone to %15.3

    changed milestone to %15.3

  • James Rushford resolved all threads

    resolved all threads

  • James Rushford added 1 commit

    added 1 commit

    Compare with previous version

  • Allure report

    allure-report-publisher generated test report!

    review-qa-blocking: :exclamation: test report for b206f705

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Manage                             | 46     | 0      | 3       | 39    | 49    | ❗     |
    | Create                             | 28     | 0      | 1       | 28    | 29    | ❗     |
    | Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
    | Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 9     | 9     | ❗     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 146    | 0      | 9       | 139   | 155   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Diana Zubova approved this merge request

    approved this merge request

  • Diana Zubova requested review from @ekigbo and removed review request for @dzubova

    requested review from @ekigbo and removed review request for @dzubova

  • :wave: @dzubova, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Setting label grouprespond based on @jrushford's group.

  • James Rushford added 114 commits

    added 114 commits

    Compare with previous version

  • Ezekiel Kigbo
  • Ezekiel Kigbo
  • James Rushford mentioned in merge request !93545 (merged)

    mentioned in merge request !93545 (merged)

  • James Rushford mentioned in merge request !94899 (merged)

    mentioned in merge request !94899 (merged)

  • Tristan Read added 1 commit

    added 1 commit

    Compare with previous version

  • Tristan Read added 1 commit

    added 1 commit

    Compare with previous version

  • Tristan Read added 1 commit

    added 1 commit

    Compare with previous version

  • Tristan Read added 867 commits

    added 867 commits

    Compare with previous version

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for 39ab7530 succeeds

    enabled an automatic merge when the pipeline for 39ab7530 succeeds

  • merged

  • Ezekiel Kigbo mentioned in commit dd430d92

    mentioned in commit dd430d92

  • James Rushford mentioned in merge request !95061 (merged)

    mentioned in merge request !95061 (merged)

  • James Rushford mentioned in merge request !95046 (merged)

    mentioned in merge request !95046 (merged)

  • added workflowstaging label and removed workflowcanary label

  • James Rushford mentioned in merge request !95638 (merged)

    mentioned in merge request !95638 (merged)

  • mentioned in commit c530a80c

  • James Rushford mentioned in commit 510b2d96

    mentioned in commit 510b2d96

  • Please register or sign in to reply
    Loading