Refactor timeline events list tests
What does this MR do and why?
Describe in detail what your merge request does and why.
As part of #344060 (closed) some refactoring of Timeineline Events List tests was needed, this is the stand alone refactoring in order to reduce MR sizes
There should be no changes other than refactoring
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added typemaintenance label
assigned to @jrushford
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @ntepluhina
,@pgascouvaillancourt
,@vitallium
,@markrian
,@ealcantara
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added frontend label
1 Warning This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Laura Meckley ( @lmeckley
) (UTC-6, 8 hours behind@jrushford
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 3.5 hours ahead of@jrushford
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Kushal Pandya
Would you mind reviewing please @agulina ?
requested review from @agulina
added maintenancerefactor label
Setting label grouprespond based on
@jrushford
's group.added grouprespond label
added 196 commits
-
5967d8b4...3a1b92da - 194 commits from branch
master
- f085d68b - Refactor timeline events list testing
- bedaf430 - Add missing fake date
-
5967d8b4...3a1b92da - 194 commits from branch
Setting label(s) devopsmonitor sectionops based on grouprespond.
added devopsmonitor sectionops labels
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
Hey @kushalpandya,
would you have time to look at this merge request, please? Thanks!
requested review from @kushalpandya
@agulina
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @kushalpandya
mentioned in merge request !93545 (merged)
mentioned in merge request !94899 (merged)
added 944 commits
-
bedaf430...12b10096 - 941 commits from branch
master
- 20777df2 - Refactor timeline events list testing
- db514f1d - Add missing fake date
- 6ad5eb39 - Add MR review suggestions
Toggle commit list-
bedaf430...12b10096 - 941 commits from branch
requested review from @kushalpandya
mentioned in merge request !95061 (merged)
enabled an automatic merge when the pipeline for 5a695221 succeeds
changed milestone to %15.3
enabled an automatic merge when the pipeline for a4b899b6 succeeds
mentioned in commit 488c61cf
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label