Remove sorting vulnerabilities by report_type
What does this MR do and why?
This MR removes sorting vulnerabilities by report_type
functionality from UI and GraphQL which has already been deprecated.
Related to Remove sorting of vulnerabilities by "report_type" (#363138 - closed).
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.3
assigned to @minac
added typefeature label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@mayra-cabrera
,@rymai
,@ahegyi
,@jivanvl
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added documentation label
1 Warning Please add a merge request subtype to this merge request. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/api/graphql/reference/index.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Avielle Wolfe ( @avielle
) (UTC+2, same timezone as@minac
)Doug Stull ( @dstull
) (UTC-4, 6 hours behind@minac
)frontend André Luís ( @andr3
) (UTC+1, 1 hour behind@minac
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 3.5 hours ahead of@minac
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e44d62ff and 8135d66c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.49 MB 3.49 MB - -0.0 % mainChunk 1.9 MB 1.9 MB - -0.0 % Significant Reduction: 10Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.application_settings.reporting 1.31 MB 1.28 MB -32.22 KB -2.4 % pages.admin.application_settings 1.23 MB 1.2 MB -32.2 KB -2.6 % pages.admin.application_settings.advanced_search 1.23 MB 1.2 MB -32.2 KB -2.5 % pages.admin.application_settings.ci_cd 1.24 MB 1.21 MB -32.2 KB -2.5 % pages.admin.application_settings.general 1.33 MB 1.3 MB -32.2 KB -2.4 % pages.admin.application_settings.integrations 1.24 MB 1.21 MB -32.2 KB -2.5 % pages.admin.application_settings.metrics_and_profiling 1.24 MB 1.2 MB -32.2 KB -2.5 % pages.admin.application_settings.repository 1.26 MB 1.22 MB -32.2 KB -2.5 % pages.admin.application_settings.service_usage_data 1.24 MB 1.2 MB -32.2 KB -2.5 % pages.groups.settings.ci_cd.show 1.27 MB 1.24 MB -32.1 KB -2.5 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 8135d66cexpand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 33 | 0 | 2 | 35 | 35 | ❗ | | Create | 28 | 0 | 1 | 28 | 29 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 8 | 135 | 141 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 78664b4f - Remove sorting vulnerabilities by report_type
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Savas Vedova
requested review from @andr3
- Resolved by Savas Vedova
requested review from @jschafer
requested review from @dskim_gitlab
@subashis
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 214 commits
-
78664b4f...76d99bdd - 213 commits from branch
master
- 8135d66c - Remove sorting vulnerabilities by report_type
-
78664b4f...76d99bdd - 213 commits from branch
removed review request for @dskim_gitlab
enabled an automatic merge when the pipeline for c120445b succeeds
mentioned in commit ab2a4f09
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request !95825 (merged)
mentioned in merge request kubitus-project/kubitus-installer!1303 (merged)