Bump Oj to v3.13.20 to fix illegal instruction errors
What does this MR do and why?
v3.13.19 was not enough to fix x86 compatibility on older processors because some SSE instructions were used by the compiler in other parts of the code base. https://github.com/ohler55/oj/pull/806 disables SSE 4.2 optimizations by default.
Diff: https://my.diffend.io/gems/oj/3.13.19/3.13.20
Relates to #368656 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stanhu
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@mayra-cabrera
,@jivanvl
,@godfat
,@ahegyi
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %15.3
added Pick into 15.3 label
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Carla Drago ( @carlad-gl
) (UTC+2, 9 hours ahead of@stanhu
)George Koltsov ( @georgekoltsov
) (UTC+1, 8 hours ahead of@stanhu
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @engwan
added 1 commit
- a689e733 - Bump Oj to v3.13.20 to fix illegal instruction errors
mentioned in issue #368656 (closed)
@engwan
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 41d2a87b succeeds
#343310 (closed) has been merged. Running a new pipeline now.
Oops: !94969 (merged) is not yet merged.
Edited by Stan Humentioned in commit 65845119
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added Pick into 15.2 label and removed Pick into 15.3 label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1303 (merged)