Skip to content

Remove settings_ci_cd.scss file

Jose Ivan Vargas requested to merge jivanvl-remove-settings-ci-cd-scss into master

What does this MR do and why?

This removes the app/assets/stylesheets/pages/settings_ci_cd.scss file as all of the rules can be converted to gitlab-ui utility classes

#239874 (closed)

Screenshots or screen recordings

Autodevops card

Before After
Screen_Shot_2022-08-03_at_12.00.52 Screen_Shot_2022-08-03_at_12.11.20

Without ci_pipeline_triggers_settings_vue_ui

Pipeline Triggers

Before After
Screen_Shot_2022-08-03_at_12.01.06 Screen_Shot_2022-08-03_at_12.11.34

With ci_pipeline_triggers_settings_vue_ui

Pipeline Triggers

Before After
Screen_Shot_2022-08-03_at_12.01.46 Screen_Shot_2022-08-03_at_12.13.04

How to set up and validate locally

To test without the ci_pipeline_triggers_settings_vue_ui feature flag

  1. Go to any project
  2. Settings -> CI/CD
  3. Check the pipeline triggers and autodevops sections

To enable the feature flag mentioned above

  1. Open the rails console bundle exec rails console
  2. Enable the feature flag with Feature.enable(:ci_pipeline_triggers_settings_vue_ui)
  3. Exit the console with CTRL + D
  4. Look into a project's settings, pipeline triggers

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jose Ivan Vargas

Merge request reports