Resolve "Devise i18n support"

Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help moving the MR forward, feel free to post @gitlab-bot help. Read more on how to get help.

To enable automated checks on your MR, please configure Danger for your fork.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @qt-gith

marked this merge request as draft

changed title from Upstream 1347 devise i18n support to Draft: Resolve "Devise i18n support"

2 Warnings

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

This merge request does not refer to an existing milestone.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Gregory Havenga (`@ghavenga`) (UTC+2)	Stan Hu (`@stanhu`) (UTC-7)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1st contribution label

mentioned in issue gitlab-jh/status-reports#150

mentioned in issue gitlab-org/quality/triage-reports#8619 (closed)

added featureenhancement label

added typefeature label

mentioned in issue gitlab-org/quality/triage-reports#8623 (closed)

added QA Technical Writing UI text backend devopsmanage groupauthentication and authorization [DEPRECATED] releasedcandidate sectiondev workflowproduction labels and removed workflowin dev label

removed sectiondev label

removed workflowproduction label

added workflowin dev label

removed QA label

removed 1st contribution label

added 1st contribution label

added sectiondev label

mentioned in issue gitlab-jh/status-reports#151

added 1345 commits

23d822cb...235e502c - 1344 commits from branch gitlab-org:master
281ab5ca - Add zh-CN.yml for i18n

Compare with previous version

changed the description

added 1 commit

f0d7ba33 - Resolve review comments

Compare with previous version

resolved all threads

marked this merge request as ready

@gitlab-bot ready

added workflowready for review label and removed workflowin dev label

@justin_ho, this Community contribution is ready for review.

Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
Add the workflowin dev label if the merge request needs action from the author. This message was generated automatically. You're welcome to improve it.

requested review from @justin_ho

approved this merge request

removed review request for @justin_ho

@justin_ho, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

@justin_ho, thanks for approving this merge request.

This is the first time the merge request is approved. Please wait for AppSec approval.

cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.

approved this merge request

added sec-planningcomplete label

requested review from @stanhu

approved this merge request

resolved all threads

merged

@stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to merge when pipeline succeeds.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.

@qt-gith, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

Leave a or a on this comment to describe your experience.
Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.