Revert the Datadog fields DSL refactor
What does this MR do and why?
This MR reverts the Datadog integration changes introduced in !90921 (merged)
The changes lead to a bug where the archive_trace_events flag was not stored in the database column, but in the properties field. This way, archive trace hooks could not be executed.
The problem might be that fields automatically create a prop_accessor even thought it looks like we check if an accessor already exists when creating a boolean field. This can be addressed in a follow-up.
How to set up and validate locally
- Switch to the
masterbranch - In rails console, activate the
datadog_integration_logs_collectionfeature.Feature.enable(:datadog_integration_logs_collection) - Go to a project -> Settings -> Integrations -> Datadog
- Enter
123as API key - Check the Enable logs collection checkbox
- Click Save changes
- In rails console, run
Integration.archive_trace_hooks - Observe that the Datadog integration you created is not included in the result
- Switch to the
andysoiron/revert-datadog-fields-refactorbranch - Reload the page
- Observe that the checkbox is not checked anymore because the value is now read from the database column
- Check the Enable logs collection checkbox
- Click Save changes
- In rails console, run
Integration.archive_trace_hooks - Observe that now the Datadog integration is now included in the result
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Andy Schoenen