Skip to content

Hide ip address label when ip address is missing

Miguel Rincon requested to merge mrincon-hide-missing-ip-address-label into master

What does this MR do and why?

In some cases, runners don't have an ip address set, we shouldn't show a label next to them.

Screenshots or screen recordings

header header
Screen_Shot_2022-07-27_at_16.57.55 Screen_Shot_2022-07-27_at_16.59.24

How to set up and validate locally

Actually I found it hard to reproduce, but there are a few runners like this in our staging environment, old records that didn't report the IP address and then were removed:

Screenshot of https://staging.gitlab.com/admin/runners?runner_type[]=INSTANCE_TYPE image

I still think this fix makes sense, and doesn't hurt users with newer runners.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miguel Rincon

Merge request reports