Skip to content

Draft: Refactor: increment failed attempts inside OTP validator object

Jessie Young requested to merge jy-refactor-increment-failed-attempts-2 into master

What does this MR do and why?

Refactors code so that user.increment_failed_attempts! is called within service objects that verify various types of OTPs.

This was a refactor suggestion from a previous MR that was left for a follow-up in order to keep that change as small as possible.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

This is a refactor so there should be no functional changes.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports