Resolve "Update `GitlabUiFormBuilder` to support rendering of the submit button with Button ViewComponent"
What does this MR do and why?
This adds a pajamas_button
option to the submit
method of our GitlabUiFormBuilder.
A = f.submit, pajamas_button: true
would render a Pajamas::ButtonComponent
as the submit button.
By default, it would use the old behavior.
The idea behind this is to allow for individual migration of each of the 160+ instances of f.submit
. We'll need to touch everyone of these anyway, to remove the then redundant CSS classes.
This approach is inspired by !89698 (merged)
Screenshots or screen recordings
No visual change intended. Let me know if you spot something odd.
How to set up and validate locally
Verify all three submit buttons that got changed in this commit look and behave as before:
- http://gdk.test:3000/admin/application_settings/repository#js-default-branch-name
- http://gdk.test:3000/admin/application_settings/general#js-merge-request-settings
- http://gdk.test:3000/flightjs/Flight/-/settings/ci_cd#auto-rollback-settings
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364777 (closed)