Skip to content

Fix: issuable search filter locale issue

What does this MR do and why?

Reason

For some reasons, the current search filter token is using the key Assignee and Reviewer but these two entries were used by other components with plural form.

For Chinese or other languages like Japanese, plural and singular form are the same, when we use __() method to translate the key here it will be using the first value in the screenshot.

image

Normally we use n__('Assignee', '%d Assignees', count) to translate the key.

In this MR, I added namespace for two keys Assignee and Reviewerto avoid ambiguity

/cc @prajnamas @orozot @qk44077907

Screenshots or screen recordings

Wrong case

image

After fix

image

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Boot GDK
  2. Go to any project you have
  3. Go to Merge Request
  4. After the page loaded, click the search input in the middle of the page.
  5. Observe.

For English users, this will make no differences, but for other languages, we can benefit from it after the entries get translated.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Wu Jeremy

Merge request reports